Extract JFR recording stream configuration into JfrMeterBinder#7531
Extract JFR recording stream configuration into JfrMeterBinder#7531schiemon wants to merge 1 commit into
JfrMeterBinder#7531Conversation
e1a4093 to
402fbb5
Compare
| * @param eventHandlerRegistrar the registrar to use for registering handlers for JFR | ||
| * events | ||
| */ | ||
| protected abstract void bindTo(MeterRegistry registry, EventHandlerRegistrar eventHandlerRegistrar); |
There was a problem hiding this comment.
I am intentionally not simply handing over the RecordingStream or EventStream as I don't want to allow the implementation to start or close the stream.
Signed-off-by: szymon.habrainski <habrainskiszymon@gmail.com>
402fbb5 to
28203e5
Compare
|
@shakuzen and I need to discuss if we want to generalize the JFR binders in the next minor release. I think we should but I'm in favor of a simpler approach, like the code you copied in this PR: main...jonatan-ivanov:micrometer:jfr-binder |
Alright, please notify me with your decision when you are ready 👍
Personally, I also like that it is simple but dislike that it leaks the |
|
@jonatan-ivanov friendly bump :) |
This PR introduces
JfrMeterBinderto unifyRecordingStreamconfiguration and JFR event handler registration for JFR-backedMeterBinders.JfrMeterBinderwas put into an newly addedmicrometer-java17module asRecodingStreamwas introduced in Java 14 and Java 17 is the next-in-line LTS version.This is also pre-work for #7384 in which we are going to introduce
JvmSafepointMetrics, afterVirtualThreadMetricsthe secondJfrMeterBinderin Micrometer.