Apply MeterFilters when building Kafka meter id for comparison#7569
Open
yoon-youngjin wants to merge 1 commit into
Open
Apply MeterFilters when building Kafka meter id for comparison#7569yoon-youngjin wants to merge 1 commit into
yoon-youngjin wants to merge 1 commit into
Conversation
KafkaMetrics built the comparison id from raw tags (plus a common-tags hack), so MeterFilters that transform tags (replaceTagValues, renameTag, ...) made the comparison id diverge from the id the registry actually stores. Stale meters were then never removed Route the comparison id through MeterRegistry#getMappedId so all configured MeterFilters are applied, and drop the common-tags workaround. See micrometer-metricsgh-7541 Signed-off-by: yoon-youngjin <dudwls143@gmail.com>
yoon-youngjin
force-pushed
the
fix/7541-kafka-metrics-meter-filter
branch
from
99a9be7 to
69f48b7
Compare
Author
|
Hi @jonatan-ivanov, this is ready for review whenever you have a chance. It targets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-7541.
KafkaMetricsbuilt the id used to compare against and remove already-registered meters from raw tags (plus a common-tags workaround), so configuredMeterFilters that transform tags (replaceTagValues,renameTag, ...) made the comparison id diverge from the id the registry actually stores. As a result, stale meters were never removed.This change routes the comparison id through
MeterRegistry#getMappedIdso all configuredMeterFilters are applied, and drops the common-tags workaround. A regression test reproduces the issue with areplaceTagValuesfilter.