docs: clarify SpelValueExpressionResolver is not in Micrometer's public API#7595
Open
won-seoop wants to merge 1 commit into
Open
Conversation
…ic API The @MeterTag examples referenced SpelValueExpressionResolver which is only available in the docs test module, not Micrometer's public API. Users who copy the snippet get a compile error. - Add a NOTE in timers.adoc explaining the class is docs-only and showing both a SpEL-backed implementation and a simple toString fallback - Add a shorter NOTE in counters.adoc cross-referencing the same example Closes micrometer-metrics#6465 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
@MeterTagsections intimers.adocandcounters.adocreferencenew SpelValueExpressionResolver(), butSpelValueExpressionResolveronly exists in the documentation test module (io.micrometer.docs) and is not part of Micrometer's public API. Users who copy the snippet get a compile error.Changes
timers.adoc: Add a NOTE after the resolver setup block explaining thatSpelValueExpressionResolveris docs-only, followed by:toString()fallback for applications that don't need SpEL evaluationcounters.adoc: Add a shorter NOTE with a cross-reference to the@Timedsection where the full implementation is shownCloses #6465
🤖 Generated with Claude Code