GH-5461: Document thread-safety expectations for MeterBinder.bindTo()#7606
Open
won-seoop wants to merge 1 commit into
Open
GH-5461: Document thread-safety expectations for MeterBinder.bindTo()#7606won-seoop wants to merge 1 commit into
won-seoop wants to merge 1 commit into
Conversation
…terBinder.bindTo() The MeterBinder interface had no documentation on bindTo(), leaving implementors uncertain about whether their implementations need to be thread-safe. Add Javadoc to bindTo() clarifying that: it is typically called once per registry at configuration time, no concurrent-call guarantee is provided by the framework, and implementations that need to support concurrent binding to multiple registries must manage their own thread safety. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #5461.
MeterBinder.bindTo()had no Javadoc at all, leaving implementors uncertain about whether their implementations need to be thread-safe. Based on the maintainer's guidance in that issue, this PR adds Javadoc tobindTo()that clarifies:bindTo()on the same instance.Test plan
🤖 Generated with Claude Code