Filter null Humio meter events#7635
Open
xfocus3 wants to merge 1 commit into
Open
Conversation
Some Humio meter writers return null when a meter has no finite attributes. Filter those null entries before joining the event stream so publish() does not emit JSON null values. Fixes micrometer-metrics#7579 Signed-off-by: Ahmed El amraouiyine <amraouiyine@gmail.com>
xfocus3
force-pushed
the
fix-7579-filter-null
branch
from
2a734cd to
1ebcfbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7579.
Summary
nullVerification
./gradlew :micrometer-registry-humio:test --tests io.micrometer.humio.HumioMeterRegistryTest.publishDropsNullMeterEvents --no-daemon./gradlew :micrometer-registry-humio:test --no-daemongit diff --check origin/main..HEAD