Skip to content

Upgrade to Spring Boot 4 and apply required compatibility changes#101

Open
obiwan87 wants to merge 1 commit into
micrometer-metrics:mainfrom
obiwan87:main
Open

Upgrade to Spring Boot 4 and apply required compatibility changes#101
obiwan87 wants to merge 1 commit into
micrometer-metrics:mainfrom
obiwan87:main

Conversation

@obiwan87

Copy link
Copy Markdown

No description provided.

@jonatan-ivanov

Copy link
Copy Markdown
Member

Thank you for the PR but both the build and the DCO checks are failing.
Please try to run ./gradlew build locally and sign the commit.

Signed-off-by: Simone Di Stefano <simone.distefano@merkurtz.de>
@obiwan87

Copy link
Copy Markdown
Author

Thank you for the PR but both the build and the DCO checks are failing. Please try to run ./gradlew build locally and sign the commit.

There you go :)

@natcza

natcza commented Jan 19, 2026

Copy link
Copy Markdown

Hi! Michael told me GitHub is the way to say hello! Mission accomplished 😊
Have a nice coding time!
Greetings,
Natalia

@Jolly5

Jolly5 commented Apr 10, 2026

Copy link
Copy Markdown

Hi everyone!
I would certainly be glad if this library were updated to Spring Boot 4, but that would break support for Spring Boot 3, which may be undesirable.

In case the maintainers decide this upgrade is not currently wanted, there is a way to provide good forward support without fully committing to Spring Boot 4. Which is to make the PrometheusRSocketClientAutoConfiguration support both Spring Boot 3 and Spring Boot 4. Specifically, replace

@AutoConfigureAfter(PrometheusMetricsExportAutoConfiguration.class)

With

@AutoConfigureAfter(name={
    "org.springframework.boot.actuate.autoconfigure.metrics.export.prometheus.PrometheusMetricsExportAutoConfiguration" // Spring Boot 3
    "org.springframework.boot.micrometer.metrics.autoconfigure.export.prometheus.PrometheusMetricsExportAutoConfiguration" // Spring Boot 4
})

For me, a similar trick has made 2.0.0-RC1 compatible with Spring Boot 4.
Notify me if that solution is preferred, I will gladly make a pull request.

Best regards,
Jolly

@klopfdreh

klopfdreh commented May 29, 2026

Copy link
Copy Markdown
Contributor

My bad I added a PR (#111) and then I saw that this was already handled here.

The issue between Spring Boot 3 and 4 is that you also need to ensure the tests are running and you need an additional dependency for that org.springframework.boot:spring-boot-micrometer-metrics

@jonatan-ivanov - the PR I provided passes all tests and DCO checks

I just mentioned in the issue #102 that it might be good to use 1.5.x for Spring Boot 3 and 2.0.x for Spring Boot 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants