Skip to content
This repository was archived by the owner on Nov 22, 2022. It is now read-only.

Update docker file on micronaut-examples java-example#74

Open
javapapo wants to merge 1 commit into
micronaut-projects:masterfrom
javapapo:patch-1
Open

Update docker file on micronaut-examples java-example#74
javapapo wants to merge 1 commit into
micronaut-projects:masterfrom
javapapo:patch-1

Conversation

@javapapo
Copy link
Copy Markdown

@javapapo javapapo commented Apr 12, 2020

UseCGroupMemoryLimitForHeap : is no longer needed on JDK 11
-noverify : I have worked on some micronaut projects and I have seen that many developers dont really understand what disabling -noverify means . I do understand that for the sake of this example you have put it intentionally - to speed things up - but unfortunately due to copy paste programming in many cases noverify ends up in production. - which is should not.

Thanks for considering

References : https://medium.com/@speakjava/jdk-11-pitfalls-for-the-unwary-e08d864065c1

`UseCGroupMemoryLimitForHeap` : is no longer needed on JDK 11
`-noverify` : I have worked on some micronaut project and I have made the observation that many developers dont really understand what disabling `-noverify` means . I do understand that for the sake of this example you have put it intentionally - to speed things up - but unfortunately due to copy paste programming in many cases noverify ends up in production. - which is should not. 

 Thanks for considering

`References` : https://medium.com/@speakjava/jdk-11-pitfalls-for-the-unwary-e08d864065c1
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 12, 2020

CLA assistant check
All committers have signed the CLA.

@javapapo javapapo changed the title Update docker file Update docker file on micronaut-examples java-example Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants