API changes: ParticleLike trait#8
Merged
Merged
Conversation
…r_)pair_indices(). This is now covered by the new ParticleLike-related changes, which is much more flexible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
ParticletoParticleLikeimplof this traitimpls that should cover the most important use cases (but also allows for new types)Particlethat can be used instead of the former blanketimplAs a consequence,
Cellgrid::(par_)pair_indices()was removed. This is covered more generically in the new particle API.The Python bindings API is unchanged though.
Documentation and examples were added for the Rust API.