Copy service.name baggage onto all span attributes#258
Merged
Conversation
The service.name baggage value (set via BaggageBuilder.OperationSource) was never copied onto span attributes because it was missing from ActivityProcessor's allow-list. Add ServiceNameKey to AttributeKeys so it is applied to all spans when set. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures that the service.name value stored in OpenTelemetry baggage (via BaggageBuilder.OperationSource(...)) is propagated onto span attributes by adding OpenTelemetryConstants.ServiceNameKey to ActivityProcessor’s global AttributeKeys allow-list.
Changes:
- Added
OpenTelemetryConstants.ServiceNameKeyto the ActivityProcessor attribute allow-list so it is coalesced onto every started span when present.
fpfp100
approved these changes
Jun 9, 2026
juliomenendez
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
service.namebaggage value, set viaBaggageBuilder.OperationSource(...), was never copied onto span attributes becauseServiceNameKeywas missing fromActivityProcessor'sAttributeKeysallow-list. As a result,OperationSource(...)had no effect on emitted telemetry.Change
Added
OpenTelemetryConstants.ServiceNameKeyto the globalAttributeKeyslist inActivityProcessor.CoalesceTagonly applies the tag when the baggage value is non-empty, so it is copied to every span only when set.Audit
Reviewed all baggage keys written by
BaggageBuilderandTurnContextExtensionsagainst the processor allow-lists.service.namewas the only baggage attribute set but not copied to spans; all others were already covered (server.address/server.portremain scoped to invoke_agent spans intentionally).Testing
dotnet buildsucceeds