Jacksonweber/enable customer sdk stats#2703
Closed
JacksonWeber wants to merge 9 commits intomicrosoft:betafrom
Closed
Jacksonweber/enable customer sdk stats#2703JacksonWeber wants to merge 9 commits intomicrosoft:betafrom
JacksonWeber wants to merge 9 commits intomicrosoft:betafrom
Conversation
| for (var i = 0; i < items.length; i++) { | ||
| if (!_isSdkStatsMetric(items[i])) { | ||
| var t = _getTelType(items[i]); | ||
| bucket[t] = (bucket[t] || 0) + 1; |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
| for (var i = 0; i < items.length; i++) { | ||
| if (!_isSdkStatsMetric(items[i])) { | ||
| var t = _getTelType(items[i]); | ||
| bucket[t] = (bucket[t] || 0) + 1; |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
…ub.com/JacksonWeber/ApplicationInsights-JS into jacksonweber/enable-customer-sdk-stats
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces SDK statistics tracking and notification enhancements to the Application Insights JavaScript SDK. The main changes add support for SDK stats telemetry, enable notification of retry/send/discard events, and update interfaces to support these features.
SDK Stats Tracking and Notification Enhancements:
SdkStatsfeature, including versioning and flush interval. [1] [2]AppInsightsSku, which tracks and flushes SDK stats telemetry at configured intervals.ISdkStatsNotifCbkandcreateSdkStatsNotifCbk._sdkStatsListenerproperty to manage the lifecycle of the stats listener.Telemetry Notification Improvements:
Enhanced NotificationManager:
eventsRetry, with corresponding constant and method inNotificationManager, to notify listeners when telemetry events are retried. [1] [2] [3] [4]Sender Plugin Enhancements:
Senderplugin to:baseTypeof telemetry items in the internal storage payload for accurate stats mapping. [1] [2]These changes collectively improve observability of SDK operations, provide more granular notifications for telemetry processing, and lay the groundwork for accurate SDK statistics reporting.