Update to release v0.23.0#139
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Incorporates v0.23.0 release updates by adding new configuration options, updating workflows for UI and subnet settings, and introducing helper scripts for URL construction and environment conversion.
- Add new config flags (ACR public access, bastion settings, DNS policy, private agent subnet, workspace consent, UI branding)
- Update GitHub workflows to pass new inputs/env vars and improve ACR login error handling
- Introduce
construct_tre_urlandconvert_azure_env_to_arm_envhelper scripts and bump devcontainer upstream version
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| config.sample.yaml | Added new configuration flags for ACR, bastion, DNS, subnet, consent, UI |
| .github/workflows/deploy_tre_reusable.yml | Exposed UI and subnet inputs; renamed ACR login step id; improved error logging |
| .github/workflows/deploy_tre_branch.yml | Added PRIVATE_AGENT_SUBNET_ID environment variable |
| .github/workflows/deploy_tre.yml | Switched to double quotes for DEVCONTAINER_TAG; added PRIVATE_AGENT_SUBNET_ID |
| .github/actions/devcontainer_run_command/action.yml | Added inputs for user management, subnet, UI text, consent flags |
| .devcontainer/scripts/convert_azure_env_to_arm_env.sh | New script to map Azure to ARM environment identifiers |
| .devcontainer/scripts/construct_tre_url.sh | New script to build TRE portal URLs based on environment |
| .devcontainer/devcontainer.json | Bumped UPSTREAM_REPO_VERSION to v0.23.0 |
Comments suppressed due to low confidence (2)
.devcontainer/scripts/construct_tre_url.sh:1
- Consider adding unit tests for 'construct_tre_url' to verify URL formatting across different environments and inputs.
#!/bin/bash
.devcontainer/scripts/convert_azure_env_to_arm_env.sh:1
- Consider adding unit tests for 'convert_azure_env_to_arm_env' to ensure all Azure environments map correctly to ARM environments.
#!/bin/bash
tamirkamara
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporate changes from release v0.23.0, including updates to configuration options for user management, UI customization, and private agent subnet access. Enhance scripts for constructing URLs and converting Azure environments. Adjust workflow settings and improve error handling during ACR login.
Fixes #138