Skip to content

Add Hardware Monitor extension - #179

Open
zhang-astronaut wants to merge 1 commit into
microsoft:mainfrom
zhang-astronaut:add-hardware-monitor
Open

zhang-astronaut wants to merge 1 commit into
microsoft:mainfrom
zhang-astronaut:add-hardware-monitor

Conversation

@zhang-astronaut

Copy link
Copy Markdown

Add zhang-astronaut.hardware-monitor (Hardware Monitor) to the Command Palette extension gallery.

Live hardware sensors via PawnIO/LHM, Dock pinning, sticky ASCII trends, offline HTML dashboard.

@zhang-astronaut

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@niels9001

Copy link
Copy Markdown
Contributor

zhang-astronaut CI failed due to incorrect Winget package id?

@zhang-astronaut

Copy link
Copy Markdown
Author

zhang-astronaut CI failed due to incorrect Winget package id?

Thanks for the review!

The package ID is correct: zhang-astronaut.HardwareMonitorCmdPal.

CI failed because that package is not in microsoft/winget-pkgs yet. The WinGet submission is still open:

microsoft/winget-pkgs#433875

Once that PR is merged, I will re-run this gallery PR’s validate check (or push an empty commit). No change is needed to extension.json in the meantime.

@niels9001

Copy link
Copy Markdown
Contributor

/azp run

@niels9001

Copy link
Copy Markdown
Contributor

zhang-astronaut I'm closing this PR due to inactivity. Feel free to re-open!

@zhang-astronaut

Copy link
Copy Markdown
Author

Hi Niels — thanks for the review.

The package ID zhang-astronaut.HardwareMonitorCmdPal is correct and matches the open WinGet PR:

microsoft/winget-pkgs#433875

CI fails only because that WinGet PR is not merged yet, so microsoft/winget-pkgs does not contain the package id yet. After #433875 merges I will re-run this gallery PR's validate check.

No change is needed to extension.json in the meantime.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants