Fix Windows CUDA inference extension build by avoiding torch/extension.h in CUDA translation units#143
Open
mathew-felix wants to merge 2 commits intomicrosoft:mainfrom
Open
Conversation
|
@mathew-felix please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a Windows build failure in
src/layers/extensions/inferencewhen compilingkernel.cuwith NVCC.Problem
The build failed in a PyTorch header (
torch/csrc/dynamo/compiled_autograd.h) with:error C2872: 'std' ambiguous symbolRoot cause (observed)
The failure occurred while compiling
kernel.cu, andtorch/extension.hwas being included in CUDA translation units / headers used bykernel.cu.Fix
torch/extension.hin CUDA-related files (kernel.cu,common.h,def.h)ATen/...,torch/types.h)torch::empty_like(...)withat::empty_like(...)inkernel.cuValidation (local, Windows)
pip install .succeeds (wheel builds and installs)python -c "import torch; import inference_extensions_cuda; print('import ok')"succeedsThis is a build-compatibility fix and does not change model logic.