Skip to content

Comments

[SPIR-V][vk::SampledTexture] #2. Add .CalculateLevelOfDetailUnclamped() and .Gather() methods for vk::SampledTexture2D type.#8070

Merged
Keenuts merged 1 commit intomicrosoft:mainfrom
luciechoi:gather
Feb 18, 2026
Merged

[SPIR-V][vk::SampledTexture] #2. Add .CalculateLevelOfDetailUnclamped() and .Gather() methods for vk::SampledTexture2D type.#8070
Keenuts merged 1 commit intomicrosoft:mainfrom
luciechoi:gather

Conversation

@luciechoi
Copy link
Collaborator

@luciechoi luciechoi commented Jan 16, 2026

Part of #7979

Implement methods for vk::SampledTexture2D:

float CalculateLevelOfDetailUnclamped(float2 location);
<Template Type>4 Gather(float2 location, [int2 offset], [uint status]);

@luciechoi
Copy link
Collaborator Author

@s-perron
(I've separated into different PRs as discussed, please see the last two commits)

Copy link
Collaborator

@s-perron s-perron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Nothing too different than what I said on the first PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

✅ With the latest revision this PR passed the C/C++ code formatter.

@luciechoi luciechoi marked this pull request as draft February 9, 2026 18:58
@luciechoi luciechoi force-pushed the gather branch 2 times, most recently from 9c197ab to 2d27226 Compare February 9, 2026 19:33
@luciechoi luciechoi marked this pull request as ready for review February 10, 2026 18:11
@s-perron
Copy link
Collaborator

LGTM but presubmits are still failing.

@luciechoi luciechoi force-pushed the gather branch 3 times, most recently from ccd8f89 to 4a17e50 Compare February 17, 2026 18:47
@luciechoi luciechoi changed the title [SPIR-V] Add .CalculateLevelOfDetailUnclamped() and .Gather() methods for vk::SampledTexture2D type. [SPIR-V][vk::SampledTexture] #2. Add .CalculateLevelOfDetailUnclamped() and .Gather() methods for vk::SampledTexture2D type. Feb 17, 2026
@s-perron
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Keenuts Keenuts enabled auto-merge (squash) February 18, 2026 15:22
@Keenuts Keenuts merged commit d50ebb9 into microsoft:main Feb 18, 2026
12 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants