[SPIR-V][vk::SampledTexture] #6. Add remaining .Gather...() methods for vk::SampledTexture2D type. #8149
Open
luciechoi wants to merge 17 commits intomicrosoft:mainfrom
Open
[SPIR-V][vk::SampledTexture] #6. Add remaining .Gather...() methods for vk::SampledTexture2D type. #8149luciechoi wants to merge 17 commits intomicrosoft:mainfrom
.Gather...() methods for vk::SampledTexture2D type. #8149luciechoi wants to merge 17 commits intomicrosoft:mainfrom
Conversation
luciechoi
changed the title
SampledTexture2D.
Implement `GetDimensions` based on new method.
SampleCmpLevel, SampleCmpGrad, SampleCmpBias
luciechoi
changed the title
SampledTexture2D..Gather...() methods for vk::SampledTexture2D type.
Keenuts
approved these changes
Feb 19, 2026
Keenuts
approved these changes
Feb 19, 2026
Collaborator
Keenuts
left a comment
Keenuts
left a comment
There was a problem hiding this comment.
LGTM for the Gather commit (parent commit in another PR has some comments)
…icrosoft#8170) Test uses `-spirv` but lacks the `REQUIRES: spirv` annotation, so it runs and fails under `-DENABLE_SPIRV_CODEGEN=OFF`. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
microsoft/hlsl-specs#783 changed the names of the linalg DXIL ops, update the implementation to reflect that. The only interesting changes are in `utils/hct/hctdb.py` and `lib/HLSL/HLOperationLower.cpp` everything else is generated code
…ateDxilComputeAndNodeCommonInputs() (microsoft#8022) As a result of microsoft#7799, the HLSL entry function can now contain `dbg.value` calls with !dbg location metadata with scopes corresponding to functions which have been inlined. The `HLSignatureLower::GenerateDxilComputeAndNodeCommonInputs()` creates `@dx.op.threadId` intrinsic calls, using the default dbg loc when creating an `IRBuilder`. When the first instruction in the entry block is one of the `dbg,value` calls, its dbg location is copied to the `@dx.op.threadId` calls. That makes the DXIL unreadable by the modern LLVM IR reader since it fails the IR module verification because of !dbg pointing to a different subprogram scope. This change sets the dbg location for IRBuilder to be the !dbg node of the first non-PHI and non-debug instruction in the block. --------- Co-authored-by: Konstantin <konstantin.pyzhov@amd.com>
…t#8167) We are updating the spir-v submodules. They contain a new pass that will linearize multi-dimensional resource arrays, and call the combine access chain pass. This means we need to fix up some tests, and we want to make sure that we can properly handle multi-dimensional resource array in DXC. Fixes microsoft#7922
Resolves the `int MatrixRef` TODO left from previous changes, as well as updates most builtins to match their final shape. This should be considered an NFC change since these builtins aren't implemented yet and instead we are just updating the shape of the reversed op slots
…icrosoft#8179) Assisted by gh copilot. Fix BitShiftRhs test input sets to avoid shift amounts >= bit width, which is undefined behavior in C++ and can cause test failures as expected values are computed via C++.
microsoft/hlsl-specs#791 splits the MulOp operation into two distinct ops. Update the placeholder code to reflect that. Interesting changes are in `gen_intrin_main`, `hctdb.py`, and `HLOperationLower.cpp`. The rest of the code is generated code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7979
GatherCmpGreen, GatherCmpBlue, GatherCmpAlpha, GatherRaw are not supported.