Skip to content

Comments

[SM6.10] Generate LinAlg DXIL overload name#8168

Closed
V-FEXrt wants to merge 1 commit intomainfrom
linalg-dxil-matrix-overload
Closed

[SM6.10] Generate LinAlg DXIL overload name#8168
V-FEXrt wants to merge 1 commit intomainfrom
linalg-dxil-matrix-overload

Conversation

@V-FEXrt
Copy link
Collaborator

@V-FEXrt V-FEXrt commented Feb 18, 2026

This change updates the infrastructure to generate overload names for the LinAlgMatrix type

When lowering a function that takes a LinAlgMatrix a unique name must be injected into the type for each unique matrix type to differentiate it from other calls to the same function. Per the spec, for LinAlgMatrix the mapping should be dx.types.LinAlgMatrix<mangling> -> m<mangling>

Ex:
dx.types.LinAlgMatrixC10M16N16U0S1 -> mC10M16N16U0S1

Adds mangled types names to dxil ops with matrix overloads
@V-FEXrt V-FEXrt force-pushed the linalg-dxil-matrix-overload branch from 2892846 to 92066f4 Compare February 18, 2026 17:53
Copy link
Collaborator

@spall spall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized there are no tests; should there be tests for this?

@hekota
Copy link
Member

hekota commented Feb 18, 2026

That is exactly the comment I was going to write. Maybe this change should be together with the first LinAlg Matrix op so it can be tested?

@V-FEXrt
Copy link
Collaborator Author

V-FEXrt commented Feb 18, 2026

Just realized there are no tests; should there be tests for this?

Nothing actually uses or lowers to this yet so it's pretty hard to test. It does get tested once the feature is used a couple PRs from now. I can try to make a contrived example to test this code but I'm hoping folks will let me wait a couple PRs and use the practical testing I've already written

@V-FEXrt
Copy link
Collaborator Author

V-FEXrt commented Feb 18, 2026

That is exactly the comment I was going to write. Maybe this change should be together with the first LinAlg Matrix op so it can be tested?

Let me see if I can reorder the commits, but I'm trying to get all these changes in independently from the ops so that I can' upload all the ops as separate / indepentent PRs

@hekota
Copy link
Member

hekota commented Feb 18, 2026

Let me see if I can reorder the commits, but I'm trying to get all these changes in independently from the ops so that I can' upload all the ops as separate / indepentent PRs

I think it's better to have the PR that has the first op to be a little bit bigger and include all the infra changes that cannot be tested without it.

@V-FEXrt
Copy link
Collaborator Author

V-FEXrt commented Feb 18, 2026

Sounds good. The commit move was easy enough

@V-FEXrt V-FEXrt closed this Feb 18, 2026
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Feb 18, 2026
@V-FEXrt V-FEXrt deleted the linalg-dxil-matrix-overload branch February 18, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants