Skip to content

Comments

[SM6.10][specs/783] Update LinAlg DXIL Op Class Names#8169

Merged
V-FEXrt merged 1 commit intomainfrom
linalg-specs-783
Feb 19, 2026
Merged

[SM6.10][specs/783] Update LinAlg DXIL Op Class Names#8169
V-FEXrt merged 1 commit intomainfrom
linalg-specs-783

Conversation

@V-FEXrt
Copy link
Collaborator

@V-FEXrt V-FEXrt commented Feb 18, 2026

microsoft/hlsl-specs#783 changed the names of the linalg DXIL ops, update the implementation to reflect that.

The only interesting changes are in utils/hct/hctdb.py and lib/HLSL/HLOperationLower.cpp everything else is generated code

@V-FEXrt V-FEXrt changed the title [SM6.10][specs/783] Update DXIL Op Names [SM6.10][specs/783] Update LinAlg DXIL Op Class Names Feb 18, 2026
Comment on lines 1173 to 1177
"LinAlgFillMatrix,LinAlgCopyConvertMatrix,"
+ "LinAlgMatrixLength,LinAlgMatrixGetCoordinate,LinAlgMatrixGetElement,LinAlgMatrixSetElement,"
+ "LinAlgMatrixStoreToDescriptor,"
+ "LinAlgMatrixLoadFromMemory,LinAlgMatrixStoreToMemory,LinAlgMatrixAccumulateToMemory,"
+ "LinAlgMatrixMulOp,LinAlgMatrixAccumulate"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have this more evenly formatted, either with evenly long lines, or each op on a separate line. Same for the case above (line 1164).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done! There isn't a terrible amount of flexibility given the length of each name but it should be better now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

microsoft/hlsl-specs#783 changed the names
of the linalg DXIL ops, update the implementation to reflect that
Copy link
Member

@hekota hekota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@V-FEXrt
Copy link
Collaborator Author

V-FEXrt commented Feb 19, 2026

@inbelic thanks!

@V-FEXrt V-FEXrt merged commit e6b4e88 into main Feb 19, 2026
13 checks passed
@V-FEXrt V-FEXrt deleted the linalg-specs-783 branch February 19, 2026 18:02
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Feb 19, 2026
luciechoi pushed a commit to luciechoi/DirectXShaderCompiler that referenced this pull request Feb 20, 2026
microsoft/hlsl-specs#783 changed the names of
the linalg DXIL ops, update the implementation to reflect that.

The only interesting changes are in `utils/hct/hctdb.py` and
`lib/HLSL/HLOperationLower.cpp` everything else is generated code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants