[SM6.10][specs/783] Update LinAlg DXIL Op Class Names#8169
Merged
Conversation
hekota
reviewed
Feb 18, 2026
utils/hct/hctdb.py
Outdated
Comment on lines
1173
to
1177
| "LinAlgFillMatrix,LinAlgCopyConvertMatrix," | ||
| + "LinAlgMatrixLength,LinAlgMatrixGetCoordinate,LinAlgMatrixGetElement,LinAlgMatrixSetElement," | ||
| + "LinAlgMatrixStoreToDescriptor," | ||
| + "LinAlgMatrixLoadFromMemory,LinAlgMatrixStoreToMemory,LinAlgMatrixAccumulateToMemory," | ||
| + "LinAlgMatrixMulOp,LinAlgMatrixAccumulate" |
Member
There was a problem hiding this comment.
It would be nice to have this more evenly formatted, either with evenly long lines, or each op on a separate line. Same for the case above (line 1164).
Collaborator
Author
There was a problem hiding this comment.
done! There isn't a terrible amount of flexibility given the length of each name but it should be better now
microsoft/hlsl-specs#783 changed the names of the linalg DXIL ops, update the implementation to reflect that
da81115 to
1d20245
Compare
inbelic
approved these changes
Feb 19, 2026
Collaborator
Author
|
@inbelic thanks! |
luciechoi
pushed a commit
to luciechoi/DirectXShaderCompiler
that referenced
this pull request
Feb 20, 2026
microsoft/hlsl-specs#783 changed the names of the linalg DXIL ops, update the implementation to reflect that. The only interesting changes are in `utils/hct/hctdb.py` and `lib/HLSL/HLOperationLower.cpp` everything else is generated code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
microsoft/hlsl-specs#783 changed the names of the linalg DXIL ops, update the implementation to reflect that.
The only interesting changes are in
utils/hct/hctdb.pyandlib/HLSL/HLOperationLower.cppeverything else is generated code