[SM6.10] LinAlg spec review: identify signature gaps vs 0035-linalg-matrix spec#8180
Draft
[SM6.10] LinAlg spec review: identify signature gaps vs 0035-linalg-matrix spec#8180
Conversation
Copilot
AI
changed the title
[WIP] Update HL LinAlg builtin signatures
[SM6.10] LinAlg spec review: identify signature gaps vs 0035-linalg-matrix spec
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed PR changes against the SM6.10 LinAlg spec (proposal 0035) and identified discrepancies between the builtin signatures and the specified DXIL ops.
Key findings
MatrixMatrixMultiplyAccumulatemissing input accumulator: Spec defineslinAlgMatrixMultiplyAccumulateasR = C + (A*B)— four distinct matrix params. Current builtin has only three (identical shape toMatrixMatrixMultiply); the input accumulatorCis absent.No
linAlgMatrixMultiplyAccumulateDXIL op inhctdb.py: OnlyLinAlgMatrixMulOp("o,o,o") exists, covering the pure-multiply case. A separate op with signature"o,o,o,o"is needed for the accumulate variant.LinAlgMatrixMulOpnaming drift: Spec names the pure-multiply oplinAlgMatrixMultiply;hctdb.pyusesLinAlgMatrixMulOp. Aligning names would improve cross-referencing.Matrix Use discrepancy in
MatrixVectorMultiply: HLSL-levellinalg::Multiply(vector, Matrix)specifies a B matrix, but the DXIL oplinAlgMatVecMulreferences "matrix A of Thread scope". Needs validation that the correct Use constraint is enforced during lowering.Missing
alignparameter:linAlgMatrixLoadFromDescriptor,linAlgMatrixStoreToDescriptor, andlinAlgMatrixAccumulateToDescriptorall include an optionalalignparam absent from the builtins. If intentionally defaulted, a comment would help.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.