Skip to content

Comments

[SM6.10] LinAlg spec review: identify signature gaps vs 0035-linalg-matrix spec#8180

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/sub-pr-8173
Draft

[SM6.10] LinAlg spec review: identify signature gaps vs 0035-linalg-matrix spec#8180
Copilot wants to merge 2 commits intomainfrom
copilot/sub-pr-8173

Conversation

Copy link
Contributor

Copilot AI commented Feb 20, 2026

Reviewed PR changes against the SM6.10 LinAlg spec (proposal 0035) and identified discrepancies between the builtin signatures and the specified DXIL ops.

Key findings

  • MatrixMatrixMultiplyAccumulate missing input accumulator: Spec defines linAlgMatrixMultiplyAccumulate as R = C + (A*B) — four distinct matrix params. Current builtin has only three (identical shape to MatrixMatrixMultiply); the input accumulator C is absent.

  • No linAlgMatrixMultiplyAccumulate DXIL op in hctdb.py: Only LinAlgMatrixMulOp ("o,o,o") exists, covering the pure-multiply case. A separate op with signature "o,o,o,o" is needed for the accumulate variant.

  • LinAlgMatrixMulOp naming drift: Spec names the pure-multiply op linAlgMatrixMultiply; hctdb.py uses LinAlgMatrixMulOp. Aligning names would improve cross-referencing.

  • Matrix Use discrepancy in MatrixVectorMultiply: HLSL-level linalg::Multiply(vector, Matrix) specifies a B matrix, but the DXIL op linAlgMatVecMul references "matrix A of Thread scope". Needs validation that the correct Use constraint is enforced during lowering.

  • Missing align parameter: linAlgMatrixLoadFromDescriptor, linAlgMatrixStoreToDescriptor, and linAlgMatrixAccumulateToDescriptor all include an optional align param absent from the builtins. If intentionally defaulted, a comment would help.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Update HL LinAlg builtin signatures [SM6.10] LinAlg spec review: identify signature gaps vs 0035-linalg-matrix spec Feb 20, 2026
Copilot AI requested a review from alsepkow February 20, 2026 00:23
Base automatically changed from linalg-update-builtin-shape to main February 20, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

3 participants