fix(storage): verify Space ownership before deletion - #139
Open
Rio Yu (rioyu123) wants to merge 1 commit into
Open
fix(storage): verify Space ownership before deletion#139Rio Yu (rioyu123) wants to merge 1 commit into
Rio Yu (rioyu123) wants to merge 1 commit into
Conversation
Rio Yu (rioyu123)
force-pushed
the
codex/fix-delete-space-ownership
branch
from
August 27, 2026 12:59
533832d to
cd97f86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.artifactsdirectoryspace.jsonbefore recursively deleting a Space directoryAn absent stable id previously fell back to a literal directory name. If that name matched another Space's title-derived directory, the blob-first sweep and
CanvasStore.destroy()could remove that Space even though its stable id was different. The same fallback could targetsetting/.The normal read/write fallback remains unchanged. Only destructive resolution is ownership-aware, so legitimate stable-id deletion and cleanup of genuine orphan blobs keep their existing behavior.
Testing
@huabu/servertypecheckCloses #90