Repository navigation
Adaptive Apps - bugfix - #531
Merged
Jan Egil Ring (janegilring) merged 2 commits intoSep 30, 2026
Merged
Jan Egil Ring (janegilring) merged 2 commits into
Jan Egil Ring (janegilring) merged 2 commits into
Conversation
…vice mesh configuration Signed-off-by: Jan Egil Ring <janegilring@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving the reliability and clarity of AKS (Azure Kubernetes Service) deployments with Istio service mesh, as well as refining role assignment logic and associated tests. The most significant changes include explicitly specifying an empty Istio profile in the Bicep template, updating deployment documentation, and tightening test and script logic for role assignments.
AKS Istio Service Mesh Improvements:
main.bicep: Explicitly adds an emptyistioobject toserviceMeshProfilewhenmodeisIstio, ensuring compliance with the managed-cluster API and preventing deployment ambiguity.README.md: Updates deployment documentation to clarify that deployment success can be inferred from offline tests or ARM validation, explains the rationale for the explicit Istio profile, and adds guidance on handling quota and subscription errors.Role Assignment Logic and Testing:
deploy-lab.ps1: Removes the unnecessary--allflag from therole assignment listcommand, making role assignment queries more efficient and less error-prone.console.Tests.ps1: Updates tests to assert the absence of the--allflag and the presence of the--scopeparameter in role assignment commands, ensuring the script changes are validated.Bicep Template Validation:
console.Tests.ps1: Adds tests to verify that the generated AKS template includes theistioproperty as apscustomobjectand that the property name is present, confirming the template change is effective.