Skip to content

Settings: Fix oobe page markdown theme color for H1 and H2#45774

Closed
vanzue wants to merge 3 commits intomainfrom
dev/vanzue/fix-oobe-theme-color
Closed

Settings: Fix oobe page markdown theme color for H1 and H2#45774
vanzue wants to merge 3 commits intomainfrom
dev/vanzue/fix-oobe-theme-color

Conversation

@vanzue
Copy link
Copy Markdown
Contributor

@vanzue vanzue commented Feb 24, 2026

Summary of the Pull Request

How to repro:
change theme in settings, observe the oobe what's new's markdown render

PR Checklist

  • Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end-user-facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

  1. Light and dark mode works as usual
  2. When switch from light to dark, dark to light, everything is colored correctly
fix-oobe-theme.mp4

@vanzue vanzue marked this pull request as ready for review February 24, 2026 14:14
@niels9001
Copy link
Copy Markdown
Collaborator

@vanzue We should fix this upstream in the MarkdownTextBlock, because this will hit us in other areas too (like CmdPal). I've asked the Toolkit team to look at it: CommunityToolkit/Labs-Windows#785

@vanzue
Copy link
Copy Markdown
Contributor Author

vanzue commented Feb 25, 2026

Great to know!

@vanzue vanzue closed this Feb 25, 2026
@vanzue vanzue deleted the dev/vanzue/fix-oobe-theme-color branch February 25, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong title color in what's new

2 participants