Switch orchestrators for executors #8
+29
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a fix to #5 since PyRIT v0.10.0 breaks PyRIT-Ship with the change from orchestrators to executors. The fix felt a bit trivial so I'm interested in hearing thoughts about my implementation. My thought process:
The main reason why it feels like a weird implementation to me is that the PromptSendingAttack executor feels like it should be used against a "victim" LLM and not be used with a "helper" LLM to generate a prompt for a different "victim" LLM, which is the proposed case. I wanted to keep the implementation as close to the original implementation as possible thus went with this direct swap.
Note: This requires the modifications I proposed in #7