Make full_name a cached_property #7706
Draft
+11
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In examples without instrument communication / significant data
storage full_name contributes significantly to runtime of
measurements. E.g. In an example such as
dond(
LinSweep(dac.ch1, start=0, stop=1, num_points=50000),
dmm.v1(),
show_progress=False,
)
It contributes 4 s out of 30 s to the runtime.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7706 +/- ##
==========================================
- Coverage 59.77% 59.76% -0.01%
==========================================
Files 352 352
Lines 31688 31692 +4
==========================================
Hits 18942 18942
- Misses 12746 12750 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In examples without instrument communication / significant data storage full_name contributes significantly to runtime of measurements.
TODO