Support codex_exec configuration aliases and fix sandbox propagation - #220
Open
RohithPariki wants to merge 1 commit into
Open
Support codex_exec configuration aliases and fix sandbox propagation#220RohithPariki wants to merge 1 commit into
RohithPariki wants to merge 1 commit into
Conversation
Contributor
|
Thanks for taking this on—the config mismatch and sandbox propagation are worth fixing. There are a few items we need addressed before merge:
Relevant Codex CLI documentation: https://learn.chatgpt.com/docs/non-interactive-mode#permissions-and-safety Once those are separated and covered, we’ll be happy to re-review the focused fix. |
…andbox propagation
RohithPariki
force-pushed
the
fix-issue-209
branch
from
August 11, 2026 22:49
32918cd to
6f2cb5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #209
Bug description
previously,
SkillOptwithcodex_execbackend skipped all rollouts or failed because:codex_harness.pyskipped passing the--sandboxflag whenever--full-autowas active (the default), causing the Codex CLI to default toworkspace-write(requiringbwrap, which fails in Docker).sandbox: danger-full-accessorcodex_cli_bin) were not mapped correctly into the internalcodex_exec_*keys during flattening, rendering them ineffective.Changes made
codex_harness.py: Updated_run_codex_cli_execto always append the--sandboxparameter alongside--full-auto, enabling user-specified sandboxes (e.g.,danger-full-access) to work in Docker.config.py: Expanded_FLATTEN_MAPto properly mapmodel.sandbox,model.codex_sandbox,model.codex_cli_bin, andmodel.codex_pathaliases tocodex_exec_sandboxandcodex_exec_path.backend_config.py&codex_backend.py: Updated environment variables to seamlessly map bothCODEX_EXEC_*andCODEX_*variable names and to synchronize them whenconfigure_codex_exec()is called.trainer.py: Passed all valid alias keys toconfigure_codex_exec()during the training setup.test_codex_config_aliases.pycovering flattening, env variable loading, and CLI sandbox parameter passing.