Open
Conversation
prove_helper Refactors the NIFS folding sumcheck to use DMR at three levels: - Inner: accumulates e[j] × v[j] over j (0..left) - Middle: accumulates f[i] × inner_result over i (0..right) - Outer: accumulates w[pair_idx] × prove_helper_result over pairs Reduces Montgomery reductions from O(pairs × right × left) to O(pairs × right + pairs + 1) for the eq-polynomial weighting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two-level delayed modular reduction to NeutronNova NIFS's prove_helper
Refactors the NIFS folding sumcheck to use DMR at three levels:
NeutronNova Results with DelayedModular Reduction:
NeutronNova ZK (instances=16, chain=64)
NeutronNova ZK (instances=8, chain=128)
Analysis
What's unchanged
NIFS sumcheck (nifs_sc): ~1.0x (no change)
The NIFS folding rounds have two main costs:
prove_helper(~40%) - Already uses DMR in both branchesLayer folding does one multiply per element and writes back immediately:
DMR requires accumulating multiple products before reducing. Single multiplies with immediate writeback cannot benefit.