Fix KeyError when LOCAL_RANK env var is not set #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use os.environ.get() with default value 0 instead of direct dict access to prevent KeyError when LOCAL_RANK is not set in the environment. This allows running on a single GPU without needing to set the environment variable. Fixes microsoft#379
Author
|
following up on this — fixes a KeyError crash when LOCAL_RANK isn't set as an environment variable (happens outside of torchrun). let me know if this looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
os.environ.get('LOCAL_RANK', 0)instead ofos.environ['LOCAL_RANK']Related Issue
Fixes #379
Test plan