Fix typo in absolute_pos_embed dimension check (C1 != C1 -> C1 != C2) #388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
utils.pyload_pretrained()where the dimension mismatch check forabsolute_pos_embedcomparesC1 != C1(alwaysFalse) instead of the intendedC1 != C2.relative_position_bias_tablecorrectly usesnH1 != nH2, confirming this is a typo.Test plan
C1->C2) matches the pattern used elsewhere in the same functionelsebranch executes either way)interpolate; now correctly logs a warning and skips