Repository navigation
Fix crash when user cancels hello dialog - #201
Merged
Merged
Conversation
Branden Bonaby (bbonaby)
approved these changes
Mar 24, 2026
Branden Bonaby (bbonaby)
pushed a commit
that referenced
this pull request
Apr 22, 2026
…()) (#202) When exceptions cross the VTL0/VTL1 boundary, the exception object's message pointer can become nullptr because VTL0 heap memory is not accessible from VTL1. Calling std::string(e.what()) or strlen(e.what()) on a nullptr triggers an access violation that fast-fails the host process. This was reproducible with HostAppUserBound (Create Key -> Cancel) and HostAppUserBoundSignVerify (Sign -> Cancel) sample apps. Fix: Add a safe_what() helper in both userboundkey.vtl1.cpp (3 sites) and userboundkey.vtl0.cpp (5 sites) that returns a fallback string when e.what() is nullptr. Note: This is distinct from the fix in PR #201 which addressed incorrect HRESULT mapping of KeyCredentialStatus enum values. That fix ensured the cancel error is reported as a real failure HRESULT; this fix hardens the catch blocks that log the error before re-throwing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a process crash (FAIL_FAST) that occurs when a user cancels the Windows Hello PIN/biometric dialog during user-bound key operations.
Added a helper function KeyCredentialStatusToHResult() that properly maps KeyCredentialStatus enum values to appropriate failure HRESULTs.
Fixed the same bug for both C++ and Rust implementations.