CLI: Initial support for volume commands#40139
Draft
AmelBawa-msft wants to merge 1 commit intofeature/wsl-for-appsfrom
Draft
CLI: Initial support for volume commands#40139AmelBawa-msft wants to merge 1 commit intofeature/wsl-for-appsfrom
AmelBawa-msft wants to merge 1 commit intofeature/wsl-for-appsfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds initial WSLC CLI support for managing named volumes (create/list/inspect/remove) and validates the new --driver argument, with E2E coverage to ensure named volumes can be used across containers.
Changes:
- Introduces new
wslc volumecommand group with create/remove/inspect/list subcommands. - Adds volume task/service/model plumbing to call existing session COM volume APIs and render output (table/json/quiet).
- Extends Windows E2E tests to validate named volume persistence across container runs/creates.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/windows/wslc/e2e/WSLCE2EContainerRunTests.cpp | Adds E2E scenarios validating named-volume write/read and multi-container persistence with container run. |
| test/windows/wslc/e2e/WSLCE2EContainerCreateTests.cpp | Adds E2E scenarios validating named-volume persistence across container create/start and subsequent containers. |
| src/windows/wslc/tasks/VolumeTasks.h | Declares volume task entry points used by the new commands. |
| src/windows/wslc/tasks/VolumeTasks.cpp | Implements volume tasks: create/delete/list/inspect, including output formatting (table/json/quiet). |
| src/windows/wslc/services/VolumeService.h / .cpp | Adds service wrapper over session COM APIs for volume CRUD/list/inspect. |
| src/windows/wslc/services/VolumeModel.h | Introduces VolumeInformation model for list output + JSON serialization. |
| src/windows/wslc/core/ExecutionContextData.h | Adds Data::Volumes mapping to store volume lists in the execution context. |
| src/windows/wslc/commands/VolumeCommand.* | Adds root volume command and wires up subcommands. |
| src/windows/wslc/commands/Volume*Command.cpp | Implements argument sets, descriptions, validation, and task pipelines for each volume subcommand. |
| src/windows/wslc/commands/RootCommand.cpp | Registers volume under the CLI root. |
| src/windows/wslc/arguments/ArgumentDefinitions.h | Adds VolumeDriver (--driver/-d) and positional VolumeName. |
| src/windows/wslc/arguments/ArgumentValidation.h / .cpp | Adds validation for the --driver argument (currently supports vhd). |
| localization/strings/en-US/Resources.resw | Adds localized help text for volume commands and new arguments. |
| --*/ | ||
| #pragma once | ||
| #include "CLIExecutionContext.h" | ||
| #include "Task.h" |
There was a problem hiding this comment.
Task.h is included but not used in this header (unlike ContainerTasks.h, which defines a Task-derived type). Dropping the unused include would reduce unnecessary coupling and rebuilds.
Suggested change
| #include "Task.h" |
|
|
||
| #pragma once | ||
|
|
||
| #include <wslc.h> |
There was a problem hiding this comment.
<wslc.h> doesn’t appear to be needed for VolumeInformation (it only uses std::string and the nlohmann JSON macro). Consider removing the unused include to keep the model header lightweight, consistent with other model headers like ImageModel.h.
Suggested change
| #include <wslc.h> |
benhillis
force-pushed
the
user/amelbawa/volume
branch
from
f5e1b45 to
b851ae9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed