Fix incorrect regeneration for IDL targets#40148
Open
OneBlue wants to merge 1 commit intofeature/wsl-for-appsfrom
Open
Fix incorrect regeneration for IDL targets#40148OneBlue wants to merge 1 commit intofeature/wsl-for-appsfrom
OneBlue wants to merge 1 commit intofeature/wsl-for-appsfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a build regression where IDL-related CMake targets are always considered out-of-date, impacting incremental builds across dependent Windows components.
Changes:
- Tracks
dlldata_<platform>.cas an output from only the final proxy-IDL MIDL invocation to avoid conflicting/duplicated outputs. - Suppresses unwanted MIDL byproducts for “no proxy” IDLs by redirecting
/iid,/proxy, and/dlldataoutputs tonul. - Attempts to add a stamp-touch step for Visual Studio incremental up-to-date tracking on the IDL custom target.
benhillis
reviewed
Apr 10, 2026
Member
benhillis
left a comment
There was a problem hiding this comment.
LGTM - thanks for cleaning up my mess ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
#40130 introduced a regression that caused the idl targets to always be considered out of date. This changes solves this by explicitly setting the target stamp file and fixing the output of the dlldata file to only one command
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed