Added CFSClean networkIsolationPolicy - #1947
Merged
Merged
Conversation
… inputs check-dependencies.yml declared networkIsolationPolicy under pool:, which is not part of the pool schema. The job was only compliant because prbuild.yml sets the policy pipeline-wide and it cascades down. Move it to templateContext.settings so the job declares its own policy correctly. signedbuild.yml had feedsToUse and nugetConfigPath indented inside the projects: | block scalar in all three DotNetCoreCLI@2 restores, so they were parsed as project glob patterns instead of task inputs and the restores were never actually pinned to src/nuget.config. Move them to the inputs level. Also add the NuGetAuthenticate@1 step ahead of each restore in signedbuild.yml, matching the other build templates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0add1f23-4df3-4efa-8237-fe45d7d5e747
There was a problem hiding this comment.
Pull request overview
This PR updates Azure Pipelines/1ES template YAMLs to standardize job network isolation behavior by setting networkIsolationPolicy: Permissive,CFSClean, and also introduces a dedicated nuget.config plus pipeline changes to authenticate and restore packages using that config.
Changes:
- Add
networkIsolationPolicy: Permissive,CFSCleanto multiple job/pipeline settings (templateContext.settingsandextends.parameters.settings). - Add
NuGetAuthenticate@1and configure restore tasks to usesrc/nuget.config. - Introduce
src/nuget.configpointing restores at an Azure Artifacts feed.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/nuget.config | Adds a NuGet configuration that clears sources and points restores to an Azure Artifacts feed. |
| build/ui-test-job.yml | Applies networkIsolationPolicy to the UI test job and updates NuGet authentication/restore behavior. |
| build/signedbuild.yml | Adds NuGet authentication and config-based restore settings to signed build jobs. |
| build/prbuild.yml | Sets pipeline-level networkIsolationPolicy in 1ES extends.parameters.settings. |
| build/check-dependencies.yml | Applies networkIsolationPolicy and uses authenticated/config-based NuGet restore for dependency checks. |
| build/build-and-unit-tests.yml | Applies networkIsolationPolicy and uses authenticated/config-based NuGet + dotnet restore for unit test builds. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
v-jitendjain
marked this pull request as ready for review
August 10, 2026 12:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates several Azure Pipelines YAML files to explicitly set the
networkIsolationPolicytoPermissive,CFSCleanfor various build, test, and dependency check jobs. This change ensures consistent network isolation settings across the pipeline, which may be required for compliance or security reasons.Pipeline configuration updates:
networkIsolationPolicy: Permissive,CFSCleanto the job pool settings inbuild/check-dependencies.ymlto control network isolation during dependency checks.networkIsolationPolicy: Permissive,CFSCleanundersettingsin thetemplateContextfor the build and unit test job inbuild/build-and-unit-tests.yml.networkIsolationPolicy: Permissive,CFSCleanto thesettingsparameters inbuild/prbuild.ymlfor PR builds.networkIsolationPolicy: Permissive,CFSCleanundersettingsin thetemplateContextfor the UI test job inbuild/ui-test-job.yml.