Skip to content

Fix DataContent.SaveToFile godoc for the empty-Name and explicit-path cases #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Quim Muntal (qmuntal) merged 1 commit into from
Sep 16, 2026
+4 −3
Merged

Fix DataContent.SaveToFile godoc for the empty-Name and explicit-path cases #1084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions message/datacontent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,10 @@ func NewDataContentFromReader(reader io.Reader, mediaType string) (*DataContent,
}

// SaveToFile writes the decoded content to path without overwriting an
// existing file. If path is empty or names an existing directory, Name is used
// as the file name; otherwise a random name and inferred extension are used.
// The returned path identifies the created file.
// existing file. If path is empty or names an existing directory, the file is
// created in that directory using Name, or a random name with an inferred
// extension when Name is empty. Otherwise the content is written to path
// verbatim. The returned path identifies the created file.
func (t *DataContent) SaveToFile(path string) (string, error) {
if t == nil {
return "", fmt.Errorf("content cannot be nil")
Expand Down
Loading