Fix DefaultToolCallFormatter godoc: it groups repeated names, not counts - #1086
Conversation
The comment claimed the output includes 'deduplication counts for repeated tool names', but the formatter emits no numeric counts - it lists each tool name once with its results grouped on ' - <result>' lines. Corrected the description.
There was a problem hiding this comment.
🟢 Approval recommended
Documentation-only correction with no unresolved issues.
Pull request overview
Updates DefaultToolCallFormatter documentation to accurately describe grouped tool results rather than numeric counts.
Changes:
- Clarifies that each tool name appears once.
- Documents grouped results beneath each tool name.
File summaries
| File | Description |
|---|---|
agent/compaction/toolresult.go |
Corrected formatter documentation. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Scope: internal-only (documentation) No
|
DefaultToolCallFormatter(agent/compaction/toolresult.go) doc says its output includes "tool names, results, and deduplication counts for repeated tool names".The function emits no numeric counts: it lists each tool name once (
orderedNames) with its results grouped beneath on- <result>lines (e.g.[Tool Calls]\nsearch:\n - found 3 docs). Corrected the comment to describe the grouping instead of non-existent counts. Doc-only change.