[dotnet-code] Clarify edge runner kind internals - #1091
Quim Muntal (qmuntal) merged 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
Pull request overview
Clarifies workflow edge-runner internals with an unexported edge-kind classifier, preserving the public API and runtime behavior.
Changes:
- Adds direct, fan-out, and fan-in edge kinds.
- Reuses classification for stateful-edge setup and telemetry metadata.
File summaries
| File | Description |
|---|---|
workflow/internal/execution/edgerunner.go |
Centralizes edge classification and integrates it into runner setup and telemetry. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Scope: internal-only Changed Go contract: None. Upstream evidence reviewed: Result: aligned. This is a pure internal refactor that consolidates duplicated fan-in/fan-out detection into a single
|
Tip
Your pull request is ready to create! 🎉 ✅
Everything is OK—the changes have been pushed to branch
dotnet-code-edge-kind-internals-20260909222836-5dd8b328a27fec17. Please review the changes, including any protected files, before creating the pull request.Create the pull request
The original pull request description is below.
Summary
Introduces a small unexported edge-kind helper in the workflow edge runner and routes telemetry/stateful-edge setup through it. This keeps the Go internals closer to the .NET workflow model's explicit EdgeKind classification while preserving the existing public API and runtime behavior.
.NET Reference
Public API and Behavior
No public Go API changed. No intentional behavior change was made.
Tests
Notes
Random .NET sample inspection covered workflow edge/run internals and shared agent JSON utilities. I rejected Run.cs because the corresponding Go run handle code already has distinct lifecycle responsibilities and any cleanup risked behavior churn. I rejected AgentJsonUtilities.cs because the Go JSON helper is already a narrow generic utility and changing serializer defaults would not be portability-only. Visible open PR checks did not show an open [dotnet-code] PR covering the workflow edge candidate; two lower-integrity PR records were unavailable to inspect. The required direct git fetch of microsoft/agent-framework was blocked by the environment, so the .NET files were inspected through the configured GitHub read bridge instead.
Closes #1050