Enable WinGet and Homebrew installer validation on PR builds#15860
Draft
Enable WinGet and Homebrew installer validation on PR builds#15860
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15860Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15860" |
radical
force-pushed
the
fix-azdo-pr-build
branch
3 times, most recently
from
ddf02e7 to
c839282
Compare
Member
Author
|
/azp run microsoft-aspire |
Contributor
|
🎬 CLI E2E Test Recordings — 56 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #24049373704 |
…mebrew scripts Rename --validate-urls to --skip-url-validation (inverted flag) for clarity. Add three-way hash resolution: local archives (--archive-root), placeholder hashes (--skip-url-validation), or download from URLs (default). Update pipeline templates to pass the new parameters. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Enable Prepare Installers stage for PR builds (previously skipped) - Download only the specific native_archives_<rid> artifacts each job needs instead of all pipeline artifacts (avoids BlobArtifacts dupes) - Pass --archive-root for local SHA256 hashing and --skip-url-validation for PR/feature-branch builds where URLs are not yet published - Remove stable-channel gate from Homebrew job so it runs for all builds Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Align the unofficial pipeline with the renamed parameter and remove the stable-channel gate from the Homebrew job. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Template tests can be flaky; marking them continueOnError prevents them from blocking the downstream Prepare Installers stage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
radical
force-pushed
the
fix-azdo-pr-build
branch
from
646731f to
6fc57c0
Compare
radical
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable the Prepare Installers stage (WinGet manifest + Homebrew cask generation) to run on PR builds in the internal pipeline, so installer changes are validated before merge.
Changes
WinGet/Homebrew scripts: Rename
--validate-urls→--skip-url-validation(inverted flag). Add three-way hash resolution: local archives (--archive-root), placeholder hashes (--skip-url-validation), or download from URLs (default).Internal pipeline (
azure-pipelines.yml): Enable Prepare Installers stage for PR builds. Download only the specificnative_archives_<rid>artifacts each job needs (avoids duplicate archives fromBlobArtifacts). Pass--archive-rootfor local SHA256 hashing and--skip-url-validationfor PR/feature-branch builds.Unofficial pipeline: Align with renamed parameters and remove stable-channel gate from Homebrew job.
Template tests: Mark as
continueOnErrorto prevent flaky template tests from blocking the Prepare Installers stage.Validation
ankj/fix-azdo-pr-build)