Skip to content

Fix quarantine/outerloop workflow failures from empty timeout arguments#15921

Merged
radical merged 3 commits intomicrosoft:mainfrom
radical:fix-main-quarantine
Apr 7, 2026
Merged

Fix quarantine/outerloop workflow failures from empty timeout arguments#15921
radical merged 3 commits intomicrosoft:mainfrom
radical:fix-main-quarantine

Conversation

@radical
Copy link
Copy Markdown
Member

@radical radical commented Apr 7, 2026

Description

PR #15917 added testSessionTimeout and testHangTimeout pass-through from specialized-test-runner.yml to run-tests.yml. When runsheet entries don't define these values, GitHub Actions passes empty strings to the workflow_call inputs — which bypasses the callee's default: values. This caused --hangdump-timeout and --timeout to receive empty arguments, making the MTP test runner print its help text and exit without running any tests.

All 6 test jobs in the quarantine workflow failed: https://github.com/microsoft/aspire/actions/runs/24064788789

Changes

1. Fix empty timeout arguments in run-tests.yml (600339ab)

  • Added || 'default' fallbacks at all 8 usage sites (4 test runner steps × 2 timeout args each)
  • Corrected input defaults from 15m/7m to 20m/10m to match the canonical values in eng/Testing.props

2. Auto-trigger quarantine/outerloop workflows on PR (e0f21436)

  • Re-enabled pull_request triggers on tests-quarantine.yml and tests-outerloop.yml with narrow paths: filters scoped to just the workflow files that affect them
  • Previously disabled in [CI] Outerloop/Quarantined tests workflows failing due to running out of space #12143 due to overly broad path filters causing disk space issues
  • This adds PR validation for the quarantine and outerloop workflows: any PR that touches run-tests.yml, specialized-test-runner.yml, tests-quarantine.yml, or tests-outerloop.yml will automatically trigger these workflows, preventing regressions like this one from going undetected

3. AGENTS.md guidance (cc95ec1e)

  • Added a note that changes to quarantine/outerloop workflow files auto-trigger validation

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • No — CI workflow fix, validated by the workflows themselves
  • Did you add public API?
    • No
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?
    • No

Copilot AI review requested due to automatic review settings April 7, 2026 07:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15921

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15921"

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes specialized (quarantine/outerloop) workflow failures caused by empty-string timeout inputs bypassing workflow_call defaults, and restores PR-trigger validation for those workflows with narrowly scoped paths: filters.

Changes:

  • Make --timeout and --hangdump-timeout resilient to empty workflow_call inputs by adding expression fallbacks at each usage site in run-tests.yml.
  • Re-enable pull_request triggers for quarantine/outerloop workflows with narrow paths: filters.
  • Document in AGENTS.md that workflow-file changes will auto-trigger quarantine/outerloop validation runs.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
AGENTS.md Adds guidance that changes to specific workflow files will trigger quarantine/outerloop validation on PRs.
.github/workflows/tests-quarantine.yml Re-enables PR trigger with a narrow paths: filter for quarantine workflow-related files.
.github/workflows/tests-outerloop.yml Re-enables PR trigger with a narrow paths: filter for outerloop workflow-related files.
.github/workflows/run-tests.yml Aligns timeout input defaults and adds `

radical and others added 3 commits April 7, 2026 03:28
…rloop tests

PR microsoft#15917 added testSessionTimeout/testHangTimeout pass-through from
specialized-test-runner.yml to run-tests.yml.  When runsheet entries
don't define these values, GitHub Actions passes empty strings to
workflow_call inputs — bypassing the callee's default: values.

This caused --hangdump-timeout and --timeout to receive empty
arguments, making the MTP test runner print its help text and exit
without running any tests.

Fix:
- Resolve effective timeout values once in job-level env vars with
  || 'default' fallbacks
- Correct input defaults from 15m/7m to 20m/10m to match the
  canonical values in eng/Testing.props

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… change

Re-enable pull_request triggers on tests-quarantine.yml and
tests-outerloop.yml with narrow paths: filters scoped to the key
orchestration workflow files (self + specialized-test-runner.yml +
run-tests.yml).

Previously disabled in microsoft#12143 due to overly broad paths filter
causing disk space issues.  The new narrow filter prevents regressions
in the quarantine/outerloop pipelines from going undetected.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
GitHub was asked to rerun all failed jobs for that attempt, and the rerun is being tracked in the rerun attempt.
The job links below point to the failed attempt jobs that matched the retry-safe transient failure rules.

@radical radical merged commit 87d7cce into microsoft:main Apr 7, 2026
534 of 540 checks passed
@radical radical deleted the fix-main-quarantine branch April 7, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants