Bump astro from 7.2.1 to 7.3.2 - #51
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The Astro bump introduces a peer-dependency mismatch with @astrojs/markdown-remark that should be resolved (and lockfile regenerated) before merging.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the site’s Astro dependency to keep the handbook’s build toolchain current and aligned with upstream fixes in the Astro 7.3.x series.
Changes:
- Bump
astrofrom^7.2.1to^7.3.2inpackage.json. - Update
package-lock.jsonto reflect the new Astro version and its transitive dependency graph changes.
File summaries
| File | Description |
|---|---|
| package.json | Updates the Astro version requested by the project. |
| package-lock.json | Updates the resolved dependency tree for the Astro bump (and related transitive updates). |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
46133bc to
7fc1beb
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
Astro 7.3.2’s peer/engine requirements are no longer aligned with the current top-level dependencies and should be reconciled to avoid install/build warnings or incompatibilities.
Review details
Suppressed comments (1)
package.json:18
- Astro 7.3.2 raises its peer requirement for
@astrojs/markdown-remark(now ^7.3.0 in package-lock.json) and pulls in undici which requires Node >=22.19.0; with the current package.json, installs may produce peer/engine warnings and the lock still pins@astrojs/markdown-remark7.2.2. Consider bumping@astrojs/markdown-remark(and sharp to match Astro’s optional dep) and declaring an engines.node floor to reflect the new transitive requirement.
"@astrojs/markdown-remark": "^7.2.2",
"@astrojs/starlight": "^0.41.7",
"@mermaid-js/layout-elk": "^0.2.2",
"astro": "^7.3.2",
"astro-mermaid": "^2.1.0",
- Files reviewed: 1/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
Bumps [astro](https://github.com/withastro/astro/tree/HEAD/packages/astro) from 7.2.1 to 7.3.2. - [Release notes](https://github.com/withastro/astro/releases) - [Changelog](https://github.com/withastro/astro/blob/main/packages/astro/CHANGELOG.md) - [Commits](https://github.com/withastro/astro/commits/astro@7.3.2/packages/astro) --- updated-dependencies: - dependency-name: astro dependency-version: 7.3.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
7fc1beb to
d3bc67f
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
Unresolved dependency peer-range and Node.js engine compatibility issues remain.
Review details
Suppressed comments (1)
package.json:17
astro@7.3.2declares@astrojs/markdown-remarkas an optional peer dependency at^7.3.0, but the lockfile still resolves the direct dependency to 7.2.2 (package-lock.json:226-228). Becauseastro.config.mjsimports this integration, the installed tree has an unsatisfied peer and npm can reject the install; regenerate the lockfile so a 7.3.x version is selected (the existing^7.2.2manifest range already permits it).
"astro": "^7.3.2",
- Files reviewed: 1/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
Update the direct markdown-remark dependency to 7.3.0 and regenerate its lock entries while preserving MDX's nested 7.2.2 dependency. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
undici 8.10.2 requires Node.js >=22.19.0, conflicting with the repository’s stated Node 22.12+ support.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Pin CI Node.js to 22.19.0 or enable check-latest in both workflows.
Review details
Suppressed comments (2)
.github/workflows/feature-build-only.yml:34
- ここで
enginesとドキュメントが Node.js 22.19.0 以上を要求するようになりましたが、node-version: 22は setup-node の既定動作ではランナーにキャッシュされた任意の 22.x を選ぶため、22.19.0 未満でnpm ci/ビルドが実行される可能性があります。最低要件をCIでも保証するため、22.19.0を明示するかcheck-latest: trueを設定してください。
# 間接依存の undici に合わせて Node 22.19.0 以上が必要。22 系の最新版を使う。
node-version: 22
.github/workflows/main-build-and-publish.yml:30
- ここで
enginesとドキュメントが Node.js 22.19.0 以上を要求するようになりましたが、node-version: 22は setup-node の既定動作ではランナーにキャッシュされた任意の 22.x を選ぶため、22.19.0 未満でnpm ci/ビルドが実行される可能性があります。最低要件をCIでも保証するため、22.19.0を明示するかcheck-latest: trueを設定してください。
# 間接依存の undici に合わせて Node 22.19.0 以上が必要。22 系の最新版を使う。
node-version: 22
- Files reviewed: 4/5 changed files
- Comments generated: 0 new
- Review effort level: Lite
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Bumps astro from 7.2.1 to 7.3.2.
Release notes
Sourced from astro's releases.
... (truncated)
Changelog
Sourced from astro's changelog.
... (truncated)
Commits
aa4949e[ci] release (#17915)42e9188fix(i18n): replace locale segment by index in fallback routing (#17907) (#17908)4b92ddcGuard setFetchHandler call in non-runnable dev entrypoint to fix sessions + m...c1a6a89fix: include .astro files in client optimizeDeps entries to prevent 504 on la...a548223Only treat literal script/style content as raw in MDX rendering (#17896)92f23cc[ci] release (#17900)0389640fix: dont use internal paths (#17899)f800de1[ci] release (#17881)1e0b7e6[ci] format4671a5cchore(deps): update react to v19 in0-cssfixture (#17888)