Make /proc/kcore acquisition better#114
Open
paulkermann wants to merge 4 commits intomicrosoft:mainfrom
Open
Conversation
bmc-msft
reviewed
Jun 29, 2022
remove whitespace from fmt
bmc-msft
reviewed
Jun 29, 2022
Contributor
|
The file offset issue is clearly a bug and should be addressed. With regards to relying on the program headers in the pseudo-elf file, I would like to do much more testing of this feature before we merge it. |
Author
|
You can use arm_now to do tests for powerpc and other archs as well if needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue in PPC64 acquisition where file offset was invalid.
Ram segments are added sequentially after the first one in the program header.
So only after finding the first physical address append blocks.
Also, this way we don't "split" some ram segments in AMD64
as in the kcore file it just apears as
so they are physically aligned and easier to manage and more data is returned.
First time doing anything in rust, so correct me if I have done something incorrectly.