Update building application logic + setting version#1190
Open
Sasinkas wants to merge 5 commits into
Open
Conversation
…irectory.Build.props for version management
…ration settings in build.common.props
…s and handle errors
Sasinkas
changed the title
Sasinkas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consolidates and modernizes the BinSkim versioning strategy by removing the legacy SetCurrentVersion.cmd script and the manually-generated src/BinaryParsers/VersionConstants.cs file, eliminating the version-stamping shell logic from BuildAndTest.cmd, and instead declaring the version once in Directory.Build.props using standard MSBuild properties (AssemblyVersion, FileVersion, Version). It enables the SDK's GenerateAssemblyInfo (while suppressing a few unneeded attributes) in build.common.props, removes the now-redundant assembly-level version attributes from the Driver's AssemblyInfo.cs, and updates BuildPackages.cmd to query the version from MSBuild at pack time—making Directory.Build.props the single source of truth for the 4.4.9.9 version and allowing a parent BinSkimInternal repo to override it when this project is consumed as a submodule.