Choose message digest for ECDSA explicitly in tests - #33
Open
Daniel James (dwhjames) wants to merge 1 commit into
Open
Choose message digest for ECDSA explicitly in tests#33Daniel James (dwhjames) wants to merge 1 commit into
Daniel James (dwhjames) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree company="Gemini" |
Some versions of OpenSSL may default to SHA-1 for the `openssl x509 -req` command. (This was the case for me.) Update Makefile.certs for generate test certificates to specify digest choice explicitly. `SHA2-384`` chosen to match the existing choice of `secp384r1` as the EC params. Related: - sigstore/cosign#2091 - golang/go#41682
Daniel James (dwhjames)
force-pushed
the
sha2-384_replace_sha1
branch
from
July 27, 2026 22:40
49a7596 to
0a61a18
Compare
Author
|
I see that you recently make changes to this part of the codebase. I had made this minor contribution last year to improve the OpenSSL compatibility of this Makefile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some versions of OpenSSL may default to SHA-1 for the
openssl x509 -reqcommand. (This was the case for me.)Update Makefile.certs for generate test certificates to specify digest choice explicitly.
SHA2-384chosen to match the existing choice ofsecp384r1as the EC params.Related: