Skip to content

Timeouts #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xingdi-eric-yuan wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Timeouts #325

xingdi-eric-yuan wants to merge 5 commits into from
+434 −29

Conversation

@xingdi-eric-yuan
Copy link
Collaborator

@xingdi-eric-yuan xingdi-eric-yuan commented Dec 19, 2025 •
edited
Loading

This PR adds timeout handling to prevent agents from hanging:

  • Azure OpenAI timeout - Set 5-minute timeout on AOAI client to prevent CLOSE_WAIT connection hangs (now raises and will be retried)
  • Command timeout - Add configurable command_timeout (default: 300s) to all terminal implementations (Docker, Kubernetes, Local) to kill blocking commands like serve_forever() or infinite loops

E.g.,

terminal:
  type: docker
  command_timeout: 300  # 5 min per command

xingdi-eric-yuan and others added 4 commits December 19, 2025 12:45
@xingdi-eric-yuan
Update azure_openai.py
4887c6a
@xingdi-eric-yuan
command timeout (for bash/eval)
44a1ae8
@xingdi-eric-yuan @claude
Fix shell escaping in timeout wrapper and update timeout message test
50b7066 
Use shlex.quote() instead of Python repr for proper shell escaping when
wrapping commands with timeout. This fixes syntax errors when commands
contain special characters like parentheses (e.g., in git apply patches).

Also update test_eval_timeout to expect the new timeout message format.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@xingdi-eric-yuan
Merge branch 'main' into aoai_timeout
3534f2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matheper matheper Awaiting requested review from matheper

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xingdi-eric-yuan