Skip to content

Rebase: Add skip_update and magma support#35

Open
JohnLangford wants to merge 2 commits intomicrosoft:mainfrom
JohnLangford:rebase/pr-27
Open

Rebase: Add skip_update and magma support#35
JohnLangford wants to merge 2 commits intomicrosoft:mainfrom
JohnLangford:rebase/pr-27

Conversation

@JohnLangford
Copy link
Copy Markdown
Contributor

Rebases #27 onto current main (post-#32 refactoring).

Conflicts in normuon.py were resolved to fit the new DistributedOrthoBase structure:

  • magma_scale state initialization added to the overridden _get_or_initialize_state
  • S (magma_scales) list extraction added to _create_ortho_tasks
  • Skip/magma masking placed after NorMuon normalization in normuon_update_megabatch_async, matching the original PR's intent

muon.py changes applied cleanly (Muon was not refactored).

Original PR description: #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants