Skip to content

Conversation

@lhecker
Copy link
Member

@lhecker lhecker commented Feb 6, 2026

This removes:

  • breakpoint
  • cold_path
  • linked_list_cursors
  • maybe_uninit_fill
  • maybe_uninit_slice
  • maybe_uninit_uninit_array_transpose
  • string_from_utf8_lossy_owned

Closes #44

@lhecker lhecker requested a review from DHowett February 6, 2026 21:38
license = "MIT"
repository = "https://github.com/microsoft/edit"
rust-version = "1.88"
rust-version = "1.93"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW this is the latest stable version which was released earlier this month. (We could support older versions if we add more shims.)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW this is the latest stable version which was released earlier this month. (We could support older versions if we add more shims.)

@lhecker Just curious, why support older versions of Rust? Why shims? Rust always works on all platforms. I think it's more correct to always prefer the Rust std and keep the code concise.

// Licensed under the MIT License.

use std::hint::cold_path;
use stdext::cold_path;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR for stabilizing cold_path was just merged by the Rust team hours ago:
rust-lang/rust#151576
Another PR for the cold_path release notes was just opened with the 1.95.0 milestone:
rust-lang/rust#152251
Rust version 1.95.0 is planned to be stable on April 16, 2026:
https://releases.rs/docs/1.95.0/

license = "MIT"
repository = "https://github.com/microsoft/edit"
rust-version = "1.88"
rust-version = "1.93"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW this is the latest stable version which was released earlier this month. (We could support older versions if we add more shims.)

@lhecker Just curious, why support older versions of Rust? Why shims? Rust always works on all platforms. I think it's more correct to always prefer the Rust std and keep the code concise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider limiting use of nightly features

2 participants