catalog v2 migration + minFLVersion check - #1114
Open
Prathik Rao (prathikr) wants to merge 6 commits into
Open
Prathik Rao (prathikr) wants to merge 6 commits into
Prathik Rao (prathikr) wants to merge 6 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Prathik Rao (prathikr)
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Alias-less responses break multiple tests, and the advertised minimum-version compatibility check is absent.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Migrates the C++ catalog client to Azure Asset Gallery v2 and updates catalog metadata handling.
Changes:
- Replaces regional catalog routing with the Asset Gallery endpoint.
- Updates request, response, pagination, and model conversion logic.
- Reworks catalog tests for the new contract.
File summaries
| File | Description |
|---|---|
azure_catalog_test.cc |
Updates catalog contract tests. |
manager.cc |
Simplifies catalog construction. |
catalog_client.h |
Updates client factory API. |
azure_model_catalog.h |
Changes defaults and removes region state. |
azure_model_catalog.cc |
Adopts the simplified client factory. |
azure_catalog_models.h |
Defines Asset Gallery models. |
azure_catalog_models.cc |
Parses and converts v2 metadata. |
azure_catalog_client.h |
Removes regional routing interfaces. |
azure_catalog_client.cc |
Implements Asset Gallery queries and pagination. |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crossRegion/toasset-gallery/based catalog fetchminFLVersioncheck based on new catalog api response