[www] fixes download button accessibility when options are outside screen height - #1115
Open
Prathik Rao (prathikr) wants to merge 2 commits into
Open
Prathik Rao (prathikr) wants to merge 2 commits into
Prathik Rao (prathikr) wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The fixed height offset can still leave focused options outside the viewport when the mobile header is expanded.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Improves keyboard accessibility by keeping dropdown options visible within the viewport.
Changes:
- Adds a scrollable maximum height to dropdown menus.
- Adds regression coverage for the new styling.
File summaries
| File | Description |
|---|---|
| www/test/accessibility.test.mjs | Verifies viewport-constrained, scrollable menus. |
| www/src/lib/components/ui/dropdown-menu/dropdown-menu-content.svelte | Constrains dropdown height and enables vertical scrolling. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1020