-
Notifications
You must be signed in to change notification settings - Fork 165
#433 - Fixes and tests for Pre-Unified G1GC and Parallel #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
7ef9111
9e191ff
343ef53
fefa69f
ec79991
62febd7
757a19a
e113ebb
a6dca4c
da9e72c
af4954d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -366,13 +366,16 @@ private void ignore(GCLogTrace trace, String line) { | |||||||||
| //2014-02-22T10:49:26.508-0100: 7.498: [GC pause (G1 Evacuation Pause) (mixed), 0.0026410 secs] | ||||||||||
| //26.893: [GC pause (G1 Evacuation Pause) (young) (to-space exhausted), 0.1709670 secs] | ||||||||||
| //115.421: [GC pause (G1 Evacuation Pause) (young) (initial-mark) (to-space exhausted), 0.0476190 secs] | ||||||||||
| //2025-03-23T03:57:20.841+0000: 661.878: [GC pause (System.gc()) (young) (initial-mark), 0.0502295 secs] | ||||||||||
| private void processYoungGenCollection(GCLogTrace trace, String line) { | ||||||||||
| boolean initialMark = trace.contains(8, "initial-mark"); | ||||||||||
| boolean tospaceExhausted = trace.contains(trace.groupCount() - 2, "to-space"); | ||||||||||
|
|
||||||||||
| if (trace.contains(7, "young")) { | ||||||||||
| if (initialMark) | ||||||||||
| forwardReference = new G1YoungInitialMark(trace.getDateTimeStamp(), trace.gcCause(3, 0), trace.getDoubleGroup(trace.groupCount())); | ||||||||||
| // jlittle-ptc: Cause was misaligned, originally pointed to group 3, but seems to be consistently in group 6. | ||||||||||
| // which is default for trace.gcCause(), and would match with other off-by-3 issues I've found. | ||||||||||
|
Comment on lines
+376
to
+377
|
||||||||||
| // jlittle-ptc: Cause was misaligned, originally pointed to group 3, but seems to be consistently in group 6. | |
| // which is default for trace.gcCause(), and would match with other off-by-3 issues I've found. | |
| // Issue #433: Cause was misaligned, originally pointed to group 3, but seems to be consistently in group 6. | |
| // This adjustment ensures consistency with other similar cases and addresses the off-by-3 issue. |
Copilot
AI
Apr 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The offset change from 9 to 12 for retrieving memory pool values should be accompanied by a brief comment or reference to issue #433 to explain the rationale and aid future maintenance.
| // #433 - All offsets in method incremented by 3 as they weren't matching the correct groups. | |
| // #433 - All offsets in method incremented by 3 as they weren't matching the correct groups. | |
| // Offset changed from 9 to 12 to correctly retrieve memory pool values. See issue #433 for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] A comment referencing issue #433 would clarify why the offset was changed from 4 to 7, ensuring consistency and easing future troubleshooting.