Ignore [] brackets while capturing date with UNIFIED_DATE_TIMESTAMP#444
Merged
karianna merged 2 commits intomicrosoft:mainfrom Jun 22, 2025
Merged
Ignore [] brackets while capturing date with UNIFIED_DATE_TIMESTAMP#444karianna merged 2 commits intomicrosoft:mainfrom
karianna merged 2 commits intomicrosoft:mainfrom
Conversation
karianna
reviewed
May 29, 2025
Member
karianna
left a comment
karianna
left a comment
There was a problem hiding this comment.
Initial pass - this looks OK, but given this class is at the heart of DateTime parsing for logs I'm going to run it through some manual regression testing also (See if there are logs without the [.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a DateTimeParseException when parsing GC logs by adjusting the regex used to capture dates.
- Updated DATE_TAG regex to include an additional capturing group for the date
- Revised the capture group indexes for unified and pre-unified tokens in fromGCLogLine()
Contributor
|
Can you provide a matching test case into DateTimeStampTest? |
Contributor
Author
|
Hi @kcpeppe, I've added the unit test. Please review and let me know if any changes are needed. |
Contributor
Author
|
@microsoft-github-policy-service agree |
karianna
approved these changes
Jun 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I made a small fix that addresses the
DateTimeParseException(#442) when parsing GC logs with RotatingGCLogFile. I’m not deeply familiar with GC internals or GC log formats, so this change is based on my understanding of the related code.Please review and advise if any improvements are needed.
Thanks!