Build and release activity separated in release pipeline#446
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR separates build and release activities in the GCToolkit Azure DevOps pipeline to comply with Microsoft security tenets, stages artifacts explicitly, and scopes release approvals.
- Renamed the build step for clarity and added
templateContext.outputsto stage artifacts. - Removed the direct
PublishPipelineArtifacttask and introduced a dedicated release job that pulls the staged artifacts. - Updated the approver list for the ESRP release task.
Comments suppressed due to low confidence (2)
.devops/gctoolkit-release.yml:68
- The
artifactNameline appears misaligned under the- input: pipelineArtifactlist item. Ensure its indentation (and preceding hyphen if needed) nests correctly under the same list element so the YAML parser includes bothinput,artifactName, andtargetPathtogether.
artifactName: staged-artifacts
.devops/gctoolkit-release.yml:208
- Double-check that the new
templateContext.outputsblock actually publishes thestaged-artifactsfor downstream jobs. If the template does not auto-handle publishing, consider reinstating an explicitPublishPipelineArtifact@1step to guarantee the artifact is available to the release job.
- - task: 1ES.PublishPipelineArtifact@1
- Disable guardian anti-malware scan, not supported on AzLinux yet. - Dry-runs should not fail the build.
…ctoolkit into dek/release-task-ify
Contributor
Author
|
Using the test pool until after the July PSU release of the Microsoft Build of OpenJDK. |
Luigi96
reviewed
Jun 27, 2025
karianna
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update our GCToolkit release pipeline to be compliant with Microsoft security tenets.