Skip to content

Build and release activity separated in release pipeline#446

Merged
d3r3kk merged 10 commits intomainfrom
dek/release-task-ify
Jun 28, 2025
Merged

Build and release activity separated in release pipeline#446
d3r3kk merged 10 commits intomainfrom
dek/release-task-ify

Conversation

@d3r3kk
Copy link
Copy Markdown
Contributor

@d3r3kk d3r3kk commented Jun 10, 2025

Update our GCToolkit release pipeline to be compliant with Microsoft security tenets.

  • Distinguish between build and release activity in the pipeline.
  • Specify artifacts that are being released.

@d3r3kk d3r3kk requested review from Copilot and johnoliver June 10, 2025 17:59
@d3r3kk d3r3kk self-assigned this Jun 10, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR separates build and release activities in the GCToolkit Azure DevOps pipeline to comply with Microsoft security tenets, stages artifacts explicitly, and scopes release approvals.

  • Renamed the build step for clarity and added templateContext.outputs to stage artifacts.
  • Removed the direct PublishPipelineArtifact task and introduced a dedicated release job that pulls the staged artifacts.
  • Updated the approver list for the ESRP release task.
Comments suppressed due to low confidence (2)

.devops/gctoolkit-release.yml:68

  • The artifactName line appears misaligned under the - input: pipelineArtifact list item. Ensure its indentation (and preceding hyphen if needed) nests correctly under the same list element so the YAML parser includes both input, artifactName, and targetPath together.
artifactName: staged-artifacts

.devops/gctoolkit-release.yml:208

  • Double-check that the new templateContext.outputs block actually publishes the staged-artifacts for downstream jobs. If the template does not auto-handle publishing, consider reinstating an explicit PublishPipelineArtifact@1 step to guarantee the artifact is available to the release job.
-            - task: 1ES.PublishPipelineArtifact@1

@d3r3kk d3r3kk marked this pull request as ready for review June 27, 2025 18:25
@d3r3kk
Copy link
Copy Markdown
Contributor Author

d3r3kk commented Jun 27, 2025

Using the test pool until after the July PSU release of the Microsoft Build of OpenJDK.

@d3r3kk d3r3kk requested a review from karianna June 27, 2025 18:30
Comment thread .devops/gctoolkit-release.yml
@karianna karianna requested a review from Luigi96 June 27, 2025 23:52
@d3r3kk d3r3kk merged commit ff4143c into main Jun 28, 2025
8 checks passed
@d3r3kk d3r3kk deleted the dek/release-task-ify branch June 28, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants