Enable GODEBUG=fips140=only with systemcrypto backends#2149
Enable GODEBUG=fips140=only with systemcrypto backends#2149gdams wants to merge 1 commit intomicrosoft/mainfrom
Conversation
| // technically a violation of draft-irtf-cfrg-det-sigs-with-noise-04 but in | ||
| // our API we don't get to know what it was, and this has no security impact. | ||
| - sig, err := ecdsa.Sign(c, sha512.New, k, rand, hash) | ||
| + // Use the FIPS module's SHA-512 directly to ensure the service indicator |
There was a problem hiding this comment.
I don't think this change is neccessary, adding a comment to remind me
Patch Consistency Review - ✅ No Issues FoundI've reviewed PR #2149 for patch consistency across the two modified patch files:
Review Findings✅ Vendor Patch Compliance: The changes to vendor dependencies (updating ✅ Dependency File Updates: The vendor patch properly updates all three required dependency files:
✅ Patch Naming Convention: Both patches follow the established naming convention (numbered prefix with descriptive names). ✅ Logical Consistency: The changes demonstrate proper coordination between patches:
✅ No Redundancy: The changes don't duplicate functionality already covered by existing patches. The new SummaryThe patch changes maintain consistency and follow the repository's patch management conventions correctly. The vendor library updates in patch 0001 and the corresponding usage in patch 0004 are well-coordinated and appropriately separated by concern.
|
Fixes: #1656
Will need documentation before merging but pushing up the code changes for testing/review