eng/pipeline: add prerequisite patches check stage#2150
Closed
gdams wants to merge 3 commits intomicrosoft/mainfrom
Closed
eng/pipeline: add prerequisite patches check stage#2150gdams wants to merge 3 commits intomicrosoft/mainfrom
gdams wants to merge 3 commits intomicrosoft/mainfrom
Conversation
Add a "Patches Apply Cleanly" stage that runs before all build/test stages. This surfaces patch application failures at the top of the PR checks list, so developers don't have to drill into the pipeline to find them. Previously, patch failures were only visible by clicking through to the pipeline run and finding the "Apply patches" step inside a specific build job. This is especially tedious during submodule updates and releases where patch conflicts are common. The new stage runs on Ubuntu 22.04 with a 10-minute timeout. All build, test, and CodeQL stages now depend on it and will be skipped if patches fail to apply.
gdams
force-pushed
the
dev/gadams/infra
branch
from
9148de0 to
df57757
Compare
dagood
requested changes
Feb 19, 2026
Member
dagood
left a comment
dagood
left a comment
There was a problem hiding this comment.
Unfortunately AzDO obscures the time spent waiting for an agent so it's hard to get exact numbers, but I don't like that this PR adds extra latency to every test run--an entire "wait for agent" delay that will always be on the hot path. (Let alone the ~1m of actual execution time.)
Member
Author
|
closing for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2148
Add a "Patches Apply Cleanly" stage that runs before all build/test stages. This surfaces patch application failures at the top of the PR checks list, so developers don't have to drill into the pipeline to find them.
Previously, patch failures were only visible by clicking through to the pipeline run and finding the "Apply patches" step inside a specific build job. This is especially tedious during submodule updates and releases where patch conflicts are common.
The new stage runs on Ubuntu 22.04 with a 10-minute timeout. All build, test, and CodeQL stages now depend on it and will be skipped if patches fail to apply.
Example of how things look when the patches don't apply cleanly: